Skip to content

mingw_open_existing: handle directories better #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

mingw_open_existing: handle directories better #5342

merged 1 commit into from
Jan 23, 2025

Conversation

@rimrul
Copy link
Member

@rimrul rimrul commented Jan 5, 2025

CreateFileW() requires FILE_FLAG_BACKUP_SEMANTICS to create a directory handle and errors out with ERROR_ACCESS_DENIED without this flag. Fall back to accessing Directory handles this way.

This fixes #5068

@rimrul
mingw_open_existing: handle directories better
fae6b7a 
CreateFileW() requires FILE_FLAG_BACKUP_SEMANTICS to create a directory
handle [1] and errors out with ERROR_ACCESS_DENIED without this flag.
Fall back to accessing Directory handles this way.

[1] https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories

This fixes git-for-windows#5068

Signed-off-by: Matthias Aßhauer <[email protected]>
rimrul
rimrul commented Jan 5, 2025
View reviewed changes
compat/mingw.c
if (handle == INVALID_HANDLE_VALUE) {
DWORD err = GetLastError();
if (err == ERROR_ACCESS_DENIED) {
DWORD attrs = GetFileAttributesW(filename);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably also check GetFileAttributesW() before the first CreateFileW() and avoid calling CreateFileW() twice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current version is fine because it optimizes for the common case, avoiding the extra GetFileAttributesW() & CreateFileW() calls for the vast majority of calls.

dscho
dscho approved these changes Jan 7, 2025
View reviewed changes
compat/mingw.c
if (handle == INVALID_HANDLE_VALUE) {
DWORD err = GetLastError();
if (err == ERROR_ACCESS_DENIED) {
DWORD attrs = GetFileAttributesW(filename);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current version is fine because it optimizes for the common case, avoiding the extra GetFileAttributesW() & CreateFileW() calls for the vast majority of calls.

@dscho
Copy link
Member

dscho commented Jan 7, 2025

It looks like t5616 has a newly-introduced flake now:

  ++ git -c protocol.version=0 -c gc.autoPackLimit=0 -c maintenance.incremental-repack.auto=1234 -C pc1 fetch --refetch origin
 error: unable to open .git/objects/pack/pack-6ac94f9c26c537ad200c52c992a627f57871f8aa.pack: No such file or directory
 fatal: unable to rename temporary '*.pack' file to '.git/objects/pack/pack-6ac94f9c26c537ad200c52c992a627f57871f8aa.pack'
 fatal: index-pack failed

I've restarted the job.

@rimrul rimrul marked this pull request as ready for review January 23, 2025 11:52
@Asask-sized Asask-sized mentioned this pull request Jan 23, 2025
Closed
dscho
dscho approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dscho dscho merged commit f045ed3 into git-for-windows:main Jan 23, 2025
49 checks passed
@dscho
Copy link
Member

dscho commented Jan 23, 2025 •
edited by gitforwindowshelper bot
Loading

/add relnote bug Git for Windows used to issue a misleading warning when .gitignore was a directory, which has been fixed.

The workflow run was started

@dscho dscho added this to the Next release milestone Jan 23, 2025
github-actions bot pushed a commit to git-for-windows/build-extra that referenced this pull request Jan 23, 2025
Add a release note (bug)
0f20286 
Git for Windows used [to issue a misleading warning when `.gitignore`
was a directory](git-for-windows/git#5068),
which has been
[fixed](git-for-windows/git#5342).

Signed-off-by: gitforwindowshelper[bot] <[email protected]>
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
6421911 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
5badc17 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
1cf2e1e 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
12b4402 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jan 27, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
93030bc 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
06125e9 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
b623fab 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
a090382 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
676ce47 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
b54abe5 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
4547146 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Feb 5, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
5070e9b 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
6ec7b8e 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
d112863 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Feb 6, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
87d1417 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit to dscho/git that referenced this pull request Feb 6, 2025
@dscho
mingw_open_existing: handle directories better (git-for-windows#5342)
7a3e109 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes git-for-windows#5068
dscho added a commit to dscho/git that referenced this pull request Feb 6, 2025
@dscho
mingw_open_existing: handle directories better (git-for-windows#5342)
c10d216 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes git-for-windows#5068
git-for-windows-ci pushed a commit that referenced this pull request Feb 13, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
d09d5d4 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Feb 13, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
543aaeb 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 17, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
9add581 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jul 19, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
307eedb 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 21, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
8373a98 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 21, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
f9f3174 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 22, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
dbe3dc7 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 22, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
1d02e42 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jul 23, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
0653ebd 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 23, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
799992e 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 23, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
52ae10a 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 24, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
034cc88 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 24, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
532403c 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 24, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
110330d 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Jul 25, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
8f90048 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
4a7f88a 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
85a1e32 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
3b52de4 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
cb17547 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
1ca41f6 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
be61492 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
fae21be 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Aug 1, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
716de57 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Aug 1, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
ae06653 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Aug 1, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
2f4c6df 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Aug 1, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
127e897 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
046b7a6 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
dscho added a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
d9dac11 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
07f03c9 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
91e4e4e 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
a43a3dc 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2025
@dscho
mingw_open_existing: handle directories better (#5342)
f549ab4 
[`CreateFileW()` requires `FILE_FLAG_BACKUP_SEMANTICS` to create a
directory
handle](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#directories)
and errors out with `ERROR_ACCESS_DENIED` without this flag. Fall back
to accessing Directory handles this way.

This fixes #5068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho dscho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.48.1

Development

Successfully merging this pull request may close these issues.

Misleading warning when a directory is named .gitignore

2 participants

@rimrul @dscho